[Merge] lp:~semiosis/livecd-rootfs/fix-for-1565985 into lp:livecd-rootfs

[Louis Zuckerman]

The proposal to merge lp:~semiosis/livecd-rootfs/fix-for-1565985 into lp:livecd-rootfs has been updated.

Description changed to:

Several problems with the official ubuntu vagrant boxes for Xenial:

- Standard packages were missing (virtualbox-guest stuff, config management stuff)
- Box name was statically assigned, limiting to only one instance per host
- Default synced folder was disabled

This change fixes all of the above issues, except for config management.
As per discussion in #ubuntu-devel we have opened a new bug for the missing config management packages: https://bugs.launchpad.net/cloud-images/+bug/1599531

Also cleaned up some inconsistent indentation.

Last of all, had to change the shebang to not use -u.  This is because clean_loops (from functions) gets called twice and the second time (by trap) has unset variables so the build would die.

As a side note, a solution to allow clean_loops to run twice under bash -u would be to use ${var_name-} instead of ${var_name} in the two variable test lines, but that was out of scope for my issues.  Just FYI.

Thank you!

For more details, see:
https://code.launchpad.net/~semiosis/livecd-rootfs/fix-for-1565985/+merge/298305
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~semiosis/livecd-rootfs/fix-for-1565985 into lp:livecd-rootfs.