[Merge] lp:~dandrader/qtubuntu/rasterGLSurface into lp:qtubuntu

Gerry Boland gerry.boland at canonical.com
Tue Jul 5 16:25:00 UTC 2016


Review: Needs Information

-    return new UbuntuOffscreenSurface(surface);
+ return new QEGLPbuffer(mEglDisplay, QSurfaceFormat::defaultFormat(), surface);

Please test this on all the devices you have to hand. I vaguely recall not using PBuffers as some driver we had didn't support it, so adopting FBO instead.

+++ src/ubuntumirclient/desktopwindow.cpp
I don't see the point in making this dummy class at all... If client requests a Desktop window, they should get a regular window back, so at least the contents will be drawn on screen. This dummy window will show nothing on screen.

Can we compare with what qtwayland does please?
-- 
https://code.launchpad.net/~dandrader/qtubuntu/rasterGLSurface/+merge/299141
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list