[Merge] lp:~morphis/ofono/ota9-suspend-fix into lp:~phablet-team/ofono/ubuntu

Mathieu Trudel-Lapierre mathieu.tl at gmail.com
Fri Jan 15 20:54:23 UTC 2016


Commented inline.

Diff comments:

> 
> === modified file 'debian/changelog'
> --- debian/changelog	2015-12-03 08:32:21 +0000
> +++ debian/changelog	2016-01-15 17:35:26 +0000
> @@ -1,3 +1,14 @@
> +ofono (1.17.bzr6910+16.04.20151203-0ubuntu1) UNRELEASED; urgency=medium
> +
> +  [ Simon Fels]

This line is unneeded. I'm not going to block the merge on it (obviously), but you should be careful to avoid such extra artefacts, especially in this case where it appears to have been added manually (I may be wrong though). The [ name ] tags are only needed if more than one people add commits, and will be added automatically by dch if that happens.

> +
> +  * voicecall: acquire wakelock when starting a HFP initated voicecall
> +    (LP: #1533716)
> +  * plugins: add android wakelock implementation
> +  * src: add wakelock abstraction
> +
> + -- Simon Fels <simon.fels at canonical.com>  Fri, 15 Jan 2016 17:00:56 +0100
> +
>  ofono (1.17.bzr6908+16.04.20151203-0ubuntu1) xenial; urgency=medium
>  
>    [ Tony Espy ]


-- 
https://code.launchpad.net/~morphis/ofono/ota9-suspend-fix/+merge/282777
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/ofono/ubuntu.



More information about the Ubuntu-reviews mailing list