[Merge] lp:~gerboland/webbrowser-app/formFactor-support into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Mon Feb 22 12:44:53 UTC 2016


> > Even if that was a sensible thing to do, we most probably don’t want
> > to get a mobile UX on a tablet. Well, at least not a 10" tablet. On
> > a 7" tablet maybe. See where the screenDiagonal property comes from?
> 
> Is your call. The goal of this was to indicate that you can learn if
> the app is running on a tablet or a desktop UI at the time.

Thanks, and that’s useful, but I’m not convinced that (or at least that *alone*) is enough to decide what the default UA string should be. I have started a conversation with design about that, we need to come to a consensus. Until that happens, I’d rather keep the current implementation based on screen size (I’m not against refining it though). 
-- 
https://code.launchpad.net/~gerboland/webbrowser-app/formFactor-support/+merge/286790
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~gerboland/webbrowser-app/formFactor-support into lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list