[Merge] lp:~renatofilho/address-book-app/no-most-called into lp:address-book-app

Gustavo Pichorim Boiko gustavo.boiko at canonical.com
Wed Dec 14 22:52:54 UTC 2016


Review: Approve

Looks good!

Diff comments:

> === modified file 'debian/control'
> --- debian/control	2016-11-24 18:54:55 +0000
> +++ debian/control	2016-12-14 13:04:55 +0000
> @@ -23,8 +23,7 @@
>                 qtdeclarative5-gsettings1.0 [amd64 armhf i386],
>                 qml-module-ofono [amd64 armhf i386],
>                 qtdeclarative5-qtcontacts-plugin [amd64 armhf i386],
> -               qtdeclarative5-ubuntu-content1 [amd64 armhf i386 s390x],
> -               qtdeclarative5-ubuntu-history0.1 [amd64 armhf i386],
> +               qtdeclarative5-ubuntu-content1 [amd64 armhf i386],

I think it is better to use [!s390x] as the supported archs might grow. Your list doesn't include arm64, but I guess that's a valid target too.

>                 qtdeclarative5-ubuntu-keyboard-extensions0.1 [amd64 armhf i386],
>                 qtdeclarative5-buteo-syncfw0.1 [amd64 armhf i386],
>                 qtdeclarative5-ubuntu-telephony-phonenumber0.1 [amd64 armhf i386],


-- 
https://code.launchpad.net/~renatofilho/address-book-app/no-most-called/+merge/313059
Your team Ubuntu Phablet Team is subscribed to branch lp:address-book-app.



More information about the Ubuntu-reviews mailing list