[Merge] lp:~peat-new/camera-app/sort-video-resolutions-list into lp:camera-app/staging
Florian Boucault
florian.boucault at canonical.com
Mon Aug 22 17:29:42 UTC 2016
The proposal to merge lp:~peat-new/camera-app/sort-video-resolutions-list into lp:camera-app/staging has been updated.
Commit Message changed to:
Sort supported video resolutions list before using it.
Originally, the code assume that the list is in ascending order. But as
some device (e.g. LG L90 Dual) send this list in descending order, and
actually we probably can't rely on it's order anyway, I decided to sort
the list before using it.
This fixes 2 issues:
1.) video resolution ordering in UI being inconsistent.
2.) when a device send this list in descending order, and unsupported
resolution is currently selected, it'll select lowest resolution,
which is sometimes actually too low for encoder. This cause recording
to fail.
For more details, see:
https://code.launchpad.net/~peat-new/camera-app/sort-video-resolutions-list/+merge/293557
--
Your team Ubuntu Phablet Team is subscribed to branch lp:camera-app/staging.
More information about the Ubuntu-reviews
mailing list