[Merge] lp:~nick-dedekind/qtubuntu/lp1596524.use-pbuffers into lp:qtubuntu

Gerry Boland gerry.boland at canonical.com
Wed Aug 17 15:26:08 UTC 2016


Review: Needs Fixing

+    if (surface->surface()->surfaceClass() == QSurface::Window)
+        return static_cast<UbuntuWindow *>(surface)->eglSurface();
+    else {
+      return static_cast<QEGLPbuffer *>(surface)->pbuffer();
+    }
and you're mixing & matching brace/no-brace style. Braces please
-- 
https://code.launchpad.net/~nick-dedekind/qtubuntu/lp1596524.use-pbuffers/+merge/303151
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list