[Merge] lp:~phablet-team/messaging-framework/set-error-when-remove-self-handle into lp:messaging-framework

[Tiago Salem Herrmann]

Review: Needs Fixing

One small remark.

Diff comments:

> 
> === modified file 'include/messaging/group_manager.h'
> --- include/messaging/group_manager.h	2016-07-01 13:46:08 +0000
> +++ include/messaging/group_manager.h	2016-08-10 07:04:35 +0000
> @@ -29,6 +29,15 @@
>  
>  namespace messaging
>  {
> +
> +enum class CancelGroupReason
> +{
> +    No,

Can we change this to None instead of No? And then update the other MR accordingly. Thanks.

> +    Kicked,
> +    Gone,
> +    Error
> +};
> +
>  /// @brief GroupManager models a textual group conversation.
>  class MESSAGING_FW_PUBLIC GroupManager : public Interface, NonCopyable, NonMovable
>  {


-- 
https://code.launchpad.net/~phablet-team/messaging-framework/set-error-when-remove-self-handle/+merge/302509
Your team Ubuntu Phablet Team is subscribed to branch lp:messaging-framework.