[Merge] lp:~phablet-team/messaging-framework/set-error-when-remove-self-handle into lp:messaging-framework
Roberto Mier Escandón
roberto.escandon at canonical.com
Wed Aug 10 06:58:48 UTC 2016
Roberto Mier Escandón has proposed merging lp:~phablet-team/messaging-framework/set-error-when-remove-self-handle into lp:messaging-framework.
Commit message:
- When cancelling group, do this:
1) remove self handle giving a reason
2) close channel
- Provided an enum of generic reasons for cancelling the group
- Removed not needed on_closed() callback in Chat object.
NOTE: This MRs should be landed along with https://code.launchpad.net/~ningbo-team/ningbo/set-reason-when-cancelling-group/+merge/302508
Requested reviews:
Ubuntu Phablet Team (phablet-team)
For more details, see:
https://code.launchpad.net/~phablet-team/messaging-framework/set-error-when-remove-self-handle/+merge/302509
- When cancelling group, do this:
1) remove self handle giving a reason
2) close channel
- Provided an enum of generic reasons for cancelling the group
- Removed not needed on_closed() callback in Chat object.
NOTE: This MRs should be landed along with https://code.launchpad.net/~ningbo-team/ningbo/set-reason-when-cancelling-group/+merge/302508
--
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/messaging-framework/set-error-when-remove-self-handle into lp:messaging-framework.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 9265 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160810/d792a906/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list