[Merge] lp:~jonas-drange/ubuntu-download-manager/retrieve-metadata into lp:ubuntu-download-manager

Michael Sheldon michael.sheldon at canonical.com
Fri Aug 5 13:40:46 UTC 2016


Review: Needs Fixing

There's an unused include added (see diff comment), other than that this looks good

Diff comments:

> 
> === modified file 'tests/downloads/daemon/test_downloads_db.cpp'
> --- tests/downloads/daemon/test_downloads_db.cpp	2015-09-21 15:35:29 +0000
> +++ tests/downloads/daemon/test_downloads_db.cpp	2016-07-17 13:14:49 +0000
> @@ -21,6 +21,7 @@
>  #include <QSqlDatabase>
>  #include <QSqlQuery>
>  #include <QSqlError>
> +#include <QDebug>

This include doesn't look to be used

>  #include <ubuntu/download_manager/metatypes.h>
>  #include <ubuntu/transfers/system/hash_algorithm.h>
>  #include <ubuntu/transfers/system/uuid_utils.h>


-- 
https://code.launchpad.net/~jonas-drange/ubuntu-download-manager/retrieve-metadata/+merge/298148
Your team Ubuntu Phablet Team is subscribed to branch lp:ubuntu-download-manager.



More information about the Ubuntu-reviews mailing list