[Merge] lp:~pat-mcgowan/messaging-app/fix-1278790 into lp:messaging-app

Pat McGowan pat.mcgowan at canonical.com
Wed Aug 3 19:27:36 UTC 2016


Pat McGowan has proposed merging lp:~pat-mcgowan/messaging-app/fix-1278790 into lp:messaging-app.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~pat-mcgowan/messaging-app/fix-1278790/+merge/301952

This adds support for showing the current character count and number of messages to be sent via SMS. It includes a new label on top of the text area showing number of characters / 160 (number of messages). It is shown once the message is over 1 line in length, per other systems.
A new settings option is added to enable the feature which is off by default.
Emojis are counted as two characters. I did not test with multibyte character sets but expect that QML TextArea does the correct thing.
See lp:1278790 
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~pat-mcgowan/messaging-app/fix-1278790 into lp:messaging-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3909 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160803/678d9308/attachment.diff>


More information about the Ubuntu-reviews mailing list