[Merge] lp:~phablet-team/indicator-network/fix-nm1.2-hotspot into lp:indicator-network

Tony Espy espy at canonical.com
Thu Apr 28 20:34:37 UTC 2016


Tony Espy has proposed merging lp:~phablet-team/indicator-network/fix-nm1.2-hotspot into lp:indicator-network.

Requested reviews:
  Pete Woods (pete-woods)

For more details, see:
https://code.launchpad.net/~phablet-team/indicator-network/fix-nm1.2-hotspot/+merge/293322

This change updates the hotspot code to not include ipv4 settings which have empty values.

This fixes an issue with NetworkManager 1.2 which rejects an improperly specified ipv4.dns value:

void nmofono::HotspotManager::Priv::addConnection() Adding new hotspot connection
Failed to add connection:  "ipv4.dns: can't set property of type 'au' from value of type 'as'"

-- 
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/indicator-network/fix-nm1.2-hotspot.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 652 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160428/78fa8706/attachment.diff>


More information about the Ubuntu-reviews mailing list