[Merge] lp:~unity-team/qtubuntu/screen-info-without-dpr into lp:qtubuntu

[Daniel d'Andrada]

Review: Needs Information

I'm digging into a failure I'm getting with applications when disconnecting an external monitor from my test laptop: eglMakeCurrent() fails with EGL_BAD_DISPLAY in UbuntuOpenGLContext::makeCurrent() (added a line about it in the DGU pad thingy).

Pushed a couple of innocuous commits to this branch while debugging it, by the way.

Finally, to the main topic of this comment:

While reading the code I noticed that UbuntuScreen gets an EGLDisplay and initializes egl. As if there were an EGLDisplay per screen.

But as far as I know, it's an EGLDisplay per MirConnection (thus per graphics driver/card or even per system [1]).

So it looks wrong to me that every single UbuntuScreen is doing this sort of process-wide initialization. I think UbuntuScreen shouldn't even be holding the EGLDisplay. This should all go to some unique,central object.

Thoughts? Did I miss something?

[1] - https://www.khronos.org/registry/implementers_guide.html#negldisplay
-- 
https://code.launchpad.net/~unity-team/qtubuntu/screen-info-without-dpr/+merge/292410
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.