[Merge] lp:~nick-dedekind/qtubuntu/bad-context into lp:qtubuntu

Gerry Boland gerry.boland at canonical.com
Mon Apr 25 12:26:15 UTC 2016


Review: Needs Fixing

Code equivalent to that in Qt's QEglPlatformContext [1], so can't complain. Have you tested all devices to be sure it has zero impact, just in case?

+++ src/ubuntumirclient/window.cpp
+ if (!ok) return;
Let's print an error instead of just ignoring

[1] https://codereview.qt-project.org/#/c/62055/
-- 
https://code.launchpad.net/~nick-dedekind/qtubuntu/bad-context/+merge/291267
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list