[Merge] lp:~fboucault/qtubuntu/fix_panel_hack_low_chrome into lp:qtubuntu

[Nick Dedekind]

Review: Needs Fixing



Diff comments:

> === modified file 'src/ubuntumirclient/window.cpp'
> --- src/ubuntumirclient/window.cpp	2016-03-14 17:37:19 +0000
> +++ src/ubuntumirclient/window.cpp	2016-04-21 11:12:13 +0000
> @@ -612,6 +613,7 @@
>          newGeometry.setY(panelHeight());
>      } else {
>          newGeometry.setY(0);
> +        newGeometry.setHeight(newGeometry.height() - panelHeight());

Unity8 will adjust the window size depending if the panel is visible or not, so you shouldn't need to adjust the height here. Doing so could end up resizing the window -panelHeight multiple times.

Not sure why it wouldn't work without. Maybe it's taking a few extra cycles to get the new size? If the server pushes the fullscreen state, it might need to go back and forth between client and server a few times to get the size to be correct.

>      }
>  
>      if (newGeometry != geometry()) {


-- 
https://code.launchpad.net/~fboucault/qtubuntu/fix_panel_hack_low_chrome/+merge/292502
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.