[Merge] lp:~boiko/messaging-framework/group_chat_interfaces into lp:messaging-framework

[Roberto Mier Escandón ]

Review: Approve

Approved, though left a pair of comments

Diff comments:

> 
> === modified file 'src/messaging/qt/tp/connection.cpp'
> --- src/messaging/qt/tp/connection.cpp	2016-03-30 19:19:19 +0000
> +++ src/messaging/qt/tp/connection.cpp	2016-04-12 13:39:03 +0000
> @@ -31,6 +31,10 @@
>  
>  #include <iostream>
>  
> +#define MQT_TP_RECIPIENT "messaging-framework-qt-tp-recipient"
> +
> +Q_DECLARE_METATYPE(messaging::Recipient::shared_ptr)

Just a comment:
There is a messaging/utils.h class with the buildings of shared pointers for any type by declaring

 /// @cond
 DEFINE_PTRS(messaging::Recipient);
 /// @endcond

maybe we can have the "types.h" that we discussed about some time before using this

> +
>  namespace msg = messaging;
>  namespace mqt = messaging::qt;
>  
> 
> === modified file 'src/messaging/qt/tp/text_channel.cpp'
> --- src/messaging/qt/tp/text_channel.cpp	2016-03-30 19:19:19 +0000
> +++ src/messaging/qt/tp/text_channel.cpp	2016-04-12 13:39:03 +0000
> @@ -402,6 +422,18 @@
>  
>  void mqt::tp::TextChannel::plug_interfaces_once()
>  {
> -    plugInterface(bctt);
> -    plugInterface(bcmi);
> +    plug_interface_if_available(bctt);
> +    plug_interface_if_available(bcmi);
> +    plug_interface_if_available(bcri);
> +    plug_interface_if_available(bcrci);
> +    plug_interface_if_available(bcgi);

Maybe we can rename bctt, bcmi, bcri, bcsntdr (Banco Santander)... :D
to be like messages_interface, room_interface, room_config_interface, etc... (though sounds not really bad this was also)

> +}
> +
> +void mqt::tp::TextChannel::plug_interface_if_available(const Tp::AbstractChannelInterfacePtr &interface)
> +{
> +    if (interface.isNull())
> +    {
> +        return;
> +    }
> +    plugInterface(interface);
>  }


-- 
https://code.launchpad.net/~boiko/messaging-framework/group_chat_interfaces/+merge/291120
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~boiko/messaging-framework/group_chat_interfaces into lp:messaging-framework.