[Merge] lp:~uriboni/webbrowser-app/larger-close-tab-button into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Tue Sep 29 09:22:20 UTC 2015
That works well, but:
- Is the change to the right anchor of mouseArea really needed? On mobile the closeButton mouse area hides mouseArea entirely anyway, no?
- I find the anchoring code in closeButton hard to read, because the conditions are not consistent. Can you maybe add a read-only boolean property to mouseArea, and use that property consistently in anchors assignments? E.g.:
readonly property bool mobile: formFactor == "mobile"
anchors {
fill: mobile ? undefined : closeIcon
…
}
--
https://code.launchpad.net/~uriboni/webbrowser-app/larger-close-tab-button/+merge/272557
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list