[Merge] lp:~mterry/webbrowser-app/switch-tab-keybinding into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue Sep 29 08:36:29 UTC 2015


LGTM, thanks for this useful contribution.

A couple of minor comments:

 - the call to focus recentView should probably be factored out to the implementation of internal.switchToTab()

 - can you update the autopilot tests in tests/autopilot/webbrowser_app/tests/test_keyboard.py to also test these new shortcuts (see test_switch_tabs)
-- 
https://code.launchpad.net/~mterry/webbrowser-app/switch-tab-keybinding/+merge/272671
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~mterry/webbrowser-app/switch-tab-keybinding into lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list