[Merge] lp:~renatofilho/buteo-sync-plugins-contacts/new-code into lp:buteo-sync-plugins-contacts

Michael Sheldon michael.sheldon at canonical.com
Mon Sep 28 13:33:11 UTC 2015


Review: Needs Information

I'm unclear on the use of stateChanged in UContactsClient now, it seems from the method definition that this has changed from providing one of a few predefined states to providing the progress percentage, however in the code there are places where it's still being called with the old states, e.g.

stateChanged(Sync::SYNC_PROGRESS_SENDING_ITEMS);

vs.

stateChanged(qRound(progress*100));
-- 
https://code.launchpad.net/~renatofilho/buteo-sync-plugins-contacts/new-code/+merge/264335
Your team Ubuntu Phablet Team is subscribed to branch lp:buteo-sync-plugins-contacts.



More information about the Ubuntu-reviews mailing list