[Merge] lp:~mhall119/webbrowser-app/alt-num-shortcut into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Mon Sep 28 08:29:41 UTC 2015


Review: Needs Fixing

QmlTests::TabsBar::test_goto_tab_keyboardshortcut consistently fails. This is because keyboard shortcuts are not handled at the TabsBar level, but in the top-level Browser component. So either that unit test needs to be removed, or the definition of these shortcuts need to be encapsulated at the TabsBar level (probably a better approach).

On a related note, given that the definition of this kind of shortcuts results in very repetitive (and thus error-prone) code, it would be good to consider instantiating them dynamically in a Component.onCompleted handler.
-- 
https://code.launchpad.net/~mhall119/webbrowser-app/alt-num-shortcut/+merge/272454
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list