[Merge] lp:~mhall119/webbrowser-app/alt-num-shortcut into lp:webbrowser-app

Riccardo Padovani riccardo at rpadovani.com
Mon Sep 28 07:59:48 UTC 2015


Review: Needs Fixing

Thanks, works quite well.

Just a note: it doesn't work when the address bar is focused.

E.g.:
0. Start the browser
1. Click CTRL+T
2. Click ALT+1

I expect to return to first tab, but instead it inserts 1 in the address bar.

BTW, I don't find any documentation about KeyboardShortcut, nor in developer.ubuntu.com (actually, a grep in ubuntu-ui-toolkit return nothing) nor in developer.qt.io (but I didn't check the source code here) - where did you find it?
-- 
https://code.launchpad.net/~mhall119/webbrowser-app/alt-num-shortcut/+merge/272454
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~mhall119/webbrowser-app/alt-num-shortcut into lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list