[Merge] lp:~morphis/phablet-tools/multiple-silos into lp:phablet-tools
Robert Bruce Park
robert.park at canonical.com
Fri Sep 25 06:52:29 UTC 2015
Why are you using $1? I don't like the look of that because the script uses `shift` a lot, if a new argument gets added later $1 may not refer to the siloname anymore. It should probably stay as $SILO for future-proofing reasons.
--
https://code.launchpad.net/~morphis/phablet-tools/multiple-silos/+merge/271621
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~morphis/phablet-tools/multiple-silos into lp:phablet-tools.
More information about the Ubuntu-reviews
mailing list