[Merge] lp:~morphis/media-hub/fix-mem-fd-leaks into lp:media-hub/stable

[Thomas Voß]

Review: Needs Fixing

Changes look good, one recommendation inline.

Diff comments:

> 
> === modified file 'src/core/media/gstreamer/playbin.h'
> --- src/core/media/gstreamer/playbin.h	2015-08-10 13:07:04 +0000
> +++ src/core/media/gstreamer/playbin.h	2015-09-23 14:05:11 +0000
> @@ -117,6 +117,7 @@
>      gstreamer::Bus bus;
>      MediaFileType file_type;
>      GstElement* video_sink;
> +    GstElement* audio_sink;

I would propose that we wrap GstElement* in std::shared_ptr instances with custom deleters, taking care of decrementing the reference count on destruction. With that, we do not run the risk of leaking instance in case of early bail outs (e.g., due to exceptions being thrown).

>      core::Connection on_new_message_connection_async;
>      bool is_seeking;
>      mutable uint64_t previous_position;


-- 
https://code.launchpad.net/~morphis/media-hub/fix-mem-fd-leaks/+merge/272087
Your team Ubuntu Phablet Team is subscribed to branch lp:media-hub/stable.