[Merge] lp:~ken-vandine/address-book-app/use_content_1_3 into lp:address-book-app

Michael Sheldon michael.sheldon at canonical.com
Tue Sep 22 12:03:36 UTC 2015


Review: Needs Fixing

Added in line comment for broken build-dep 

Diff comments:

> === modified file 'debian/control'
> --- debian/control	2015-05-14 21:23:43 +0000
> +++ debian/control	2015-09-21 15:16:20 +0000
> @@ -15,7 +15,7 @@
>                 qtdeclarative5-gsettings1.0 [i386 amd64 armhf],
>                 qtdeclarative5-ofono0.2 [i386 amd64 armhf],
>                 qtdeclarative5-qtcontacts-plugin [i386 amd64 armhf],
> -               qtdeclarative5-ubuntu-content1 [i386 amd64 armhf],
> +               qtdeclarative5-ubuntu-content1 [i386 amd64 armhf] (>= 0.1),

I think this should be:

qtdeclarative5-ubuntu-content1 (>= 0.1) [i386 amd64 armhf],

Otherwise it fails to parse

>                 qtdeclarative5-ubuntu-history0.1 [i386 amd64 armhf],
>                 qtdeclarative5-ubuntu-keyboard-extensions0.1 [i386 amd64 armhf],
>                 qtdeclarative5-ubuntu-syncmonitor0.1 [i386 amd64 armhf],


-- 
https://code.launchpad.net/~ken-vandine/address-book-app/use_content_1_3/+merge/271825
Your team Ubuntu Phablet Team is subscribed to branch lp:address-book-app.



More information about the Ubuntu-reviews mailing list