[Merge] lp:~phablet-team/network-manager/rm-scofono-plugin-dbus-wily into lp:~network-manager/network-manager/ubuntu
Mathieu Trudel-Lapierre
mathieu.tl at gmail.com
Mon Sep 21 14:17:44 UTC 2015
Review: Needs Information
This sounds very very wrong, even if it might not have been used (which also sounds wrong).
The purpose of this code is to read in any new connections that might have been created by ofono: there is no other way to do this except outside of the modem plugin code. I think this code in particular is important for when users create brand new connections while the system is running; otherwise they might have to restart NetworkManager (not simple from the phone).
New connection creation would require this because the connection needs to be created at the ofono level to have all the necessary data (username, proxy, etc.), and from there, detected by NM and read into a NMConnection object.
--
https://code.launchpad.net/~phablet-team/network-manager/rm-scofono-plugin-dbus-wily/+merge/271709
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/network-manager/fix-ofono-plugin-mem-leaks-wily.
More information about the Ubuntu-reviews
mailing list