[Merge] lp:~phablet-team/network-manager/lp1480877-wifi-rm-dup-scan-signals into lp:~network-manager/network-manager/ubuntu

Tony Espy espy at canonical.com
Fri Sep 18 14:45:31 UTC 2015


The proposal to merge lp:~phablet-team/network-manager/lp1480877-wifi-rm-dup-scan-signals into lp:~network-manager/network-manager/ubuntu has been updated.

Description changed to:

This change fixes a problem where duplicate (2-3x) AccessPoint 'LastSeen' PropertiesChanged signals are generated each time a WiFi scan completes.  This can be seen by running:

dbus-monitor --system --profile "type='signal',sender='org.freedesktop.NetworkManager'"

...and waiting for a scan to occur.  You'll see 2-3 PropsChanged for each AccessPoint after a scan.  From then on, you'll only see changes for AccessPoint/0 until the next scan happens.

The change makes cull_scan_list the function responsible for updating an AP's last-seen property, and ensures that scan_done_cb is the only function that calls cull_scan_list.  It also removes the bss_updated_cb function, as its only purpose was to update the last-seen property and schedule yet another scanlist cull.

For more details, see:
https://code.launchpad.net/~phablet-team/network-manager/lp1480877-wifi-rm-dup-scan-signals/+merge/271575
-- 
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/network-manager/lp1480877-wifi-rm-dup-scan-signals.



More information about the Ubuntu-reviews mailing list