[Merge] lp:~uriboni/webbrowser-app/reset-focus-tab-change into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue Sep 1 10:36:18 UTC 2015


Review: Needs Fixing

33	+        if not self.main_window.wide:
34	+            self.skipTest("Only on wide form factors")

This is not the correct check. "desktop" and wide are not equivalent. A tablet in landscape mode is a wide form factor, but it doesn’t necessarily have a physical keyboard plugged in. I am aware that this "desktop" form factor thing will break easily when we get to corner cases (tablet with a keyboard, or desktop with a touch screen, …), and this will need fixing, but for now this is what we use to identify a device that has a reasonably wide screen and a physical keyboard.
-- 
https://code.launchpad.net/~uriboni/webbrowser-app/reset-focus-tab-change/+merge/269083
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list