[Merge] lp:~rpadovani/webbrowser-app/remove-404-history into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue Sep 1 07:38:15 UTC 2015


Thanks Riccardo. This looks good to me but for one small detail: in browser.py, the implementation of get_history_view() should be updated to select the class names, not strings, i.e.:

    self.select_single(HistoryView)

I’m not even sure how this currently works (but it seems it does).

Also, moving get_expanded_history_view to just after get_history_view would make the code more readable I think.
-- 
https://code.launchpad.net/~rpadovani/webbrowser-app/remove-404-history/+merge/259313
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list