[Merge] lp:~uriboni/webbrowser-app/find-in-page-focus into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Fri Oct 23 10:52:56 UTC 2015


Review: Needs Fixing

> However for some (still unclear) reason simply setting
> chrome.focus = true will in some cases leave the AddressBar unfocused

It took me a bit of digging down the code, but I understood what’s going on there. Wrong expectations with focus scope :) See my comment on the bug report (https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1508130/comments/1).

With that, your fix is perfectly fine, but the comment becomes useless, so please remove it.
-- 
https://code.launchpad.net/~uriboni/webbrowser-app/find-in-page-focus/+merge/275329
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list