[Merge] lp:~uriboni/webbrowser-app/find-in-page-focus into lp:webbrowser-app

Ugo Riboni ugo.riboni at canonical.com
Fri Oct 23 09:22:04 UTC 2015


> The changes to AddressBar.qml could be simplified quite a bit, by basically
> reverting them and making the width of the primary item conditional on its
> 'visible' property:
> 
>     width: visible ? iconsRow.width + units.gu(1) : 0


The primary item should be 1gu wide when no icons are visible, not zero as you suggest.
But in any case it does not seem like such a big simplification to me and i personally prefer that each icon has its visible state defined independently.
-- 
https://code.launchpad.net/~uriboni/webbrowser-app/find-in-page-focus/+merge/275329
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~uriboni/webbrowser-app/find-in-page-focus into lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list