[Merge] lp:~mvo/ubuntu/wily/initramfs-tools-ubuntu-core/new-and-old into lp:ubuntu/initramfs-tools-ubuntu-core

Oliver Grawert ogra at ubuntu.com
Mon Oct 19 12:17:08 UTC 2015


there is one line that makes me itch a bit ....
after we mount $rootmnt from $writable_mnt we move $writable_mnt underneath $rootmnt, so we are effectively pulling out the floor under ourselves. 
while i'm not sure what the implications of this actually are (since run-init makes everything above $rootmnt invisible anyway once we switch to the real root) I wonder if we shouldnt use --bind instead of --move (thats line 197 below)

mount --move "$writable_mnt" "${rootmnt}/writable"
-- 
https://code.launchpad.net/~mvo/ubuntu/wily/initramfs-tools-ubuntu-core/new-and-old/+merge/274875
Your team Ubuntu branches is requested to review the proposed merge of lp:~mvo/ubuntu/wily/initramfs-tools-ubuntu-core/new-and-old into lp:ubuntu/initramfs-tools-ubuntu-core.



More information about the Ubuntu-reviews mailing list