[Merge] lp:~uriboni/webbrowser-app/media-access into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Mon Oct 19 11:19:09 UTC 2015


Review: Needs Fixing

There’s still one remaining trailing semi-colon in JS code (in Browser.qml).

The import of "../UrlUtils.js" in MediaAccessDialog.qml is unused. So is "id: dialog".

In MediaAccessDialog.qml, the comment for translators could be more specific (e.g. "requesting access *to the microphone/camera*"). Keep in mind that translators are not expected to go read the code to figure out the context of a string.

In SettingsDeviceSelector.qml, shouldn’t updateDefaultDevice() be called when isAudio changes, too?
-- 
https://code.launchpad.net/~uriboni/webbrowser-app/media-access/+merge/272919
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list