[Merge] lp:~uriboni/webbrowser-app/media-access into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Mon Oct 19 07:05:59 UTC 2015


For consistency with the rest of the codebase, can you please remove the trailing semi-colons in JS code embedded in QML?

get_deny_button and get_allow_button are used only to have the tests click those buttons, maybe the methods could be transformed into click_*_button (with a corresponding autopilot.logging.log_action decorator, see other similar methods in browser.py).

While testing this branch on desktop, I realized that having a modal dialog displayed doesn’t inhibit keyboard shortcuts. As this isn’t specific to this branch, I filed bug #1507468 to track the issue, and we can address it separately. Just a FYI.

-- 
https://code.launchpad.net/~uriboni/webbrowser-app/media-access/+merge/272919
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list