[Merge] lp:~uriboni/webbrowser-app/media-access into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Wed Oct 14 10:23:44 UTC 2015


Review: Needs Fixing

In InputDevicesModel.qml, to avoid the double "Oxide." prefix, you can simply import com.canonical.Oxide 1.9 as an unnamed import.


What’s the use of InputDevicesModel.qml? Oxide.available{Audio,Video}CaptureDevices is a list of variants, do we really need to convert that to an array of string ids? Can’t we have direct references to Oxide.available{Audio,Video}CaptureDevices in SettingsDeviceSelector.qml ?


When running the autopilot tests, I’m seeing the following warning in the JS console:
    [JS] (:0) getUserMedia() is deprecated on insecure origins, and support will be removed in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.
This is out of scope for this MR, but we need to think about supporting https in our autopilot tests.


webbrowser_app.tests.test_media_access_permission.TestMediaAccessPermission.test_allow fails locally with the following traceback:

Traceback (most recent call last):
  File "/home/osomon/dev/phablet/browser/webbrowser-app/tests/autopilot/webbrowser_app/tests/test_media_access_permission.py", line 52, in test_allow
    self.main_window.wait_until_page_loaded(url)
  File "/home/osomon/dev/phablet/browser/webbrowser-app/tests/autopilot/webbrowser_app/emulators/browser.py", line 45, in wait_until_page_loaded
    webview.url.wait_for(url)
  File "/usr/lib/python3/dist-packages/autopilot/introspection/types.py", line 180, in wait_for
    failure_msg))
AssertionError: After 10.0 seconds test on WebViewImpl.url failed: 'http://test/media/v' != dbus.String('http://test/test2', variant_level=1)

Could it be because I don’t have a webcam plugged into my laptop?
-- 
https://code.launchpad.net/~uriboni/webbrowser-app/media-access/+merge/272919
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list