[Merge] lp:~nick-dedekind/platform-api/lp1351109.destroy-haptic-instance into lp:platform-api

Gerry Boland gerry.boland at canonical.com
Mon Oct 12 14:49:56 UTC 2015


I'd be happy to approve this, but the purpose of the pointer "Holder" isn't clear to me. It doesn't scope the pointer, nor prevent copying, so I don't see why it's there at all.

I would like someone more familiar with it to give the yay/nay.
-- 
https://code.launchpad.net/~nick-dedekind/platform-api/lp1351109.destroy-haptic-instance/+merge/273190
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~nick-dedekind/platform-api/lp1351109.destroy-haptic-instance into lp:platform-api.



More information about the Ubuntu-reviews mailing list