[Merge] lp:~uriboni/webbrowser-app/topsite-previews into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Thu Oct 8 20:20:05 UTC 2015


A couple of minor comments, we’re definitely getting there!

 - Given that internal.getOpenPages() is called in only one place, its usefulness as a function is low. Can you inline that code in the onTriggered implementation of the timer?

 - The interactive property of the grid view in narrow mode should be set to false, otherwise if I start flicking on the grid only the grid moves, whereas I would expect the entire page to move.

I haven’t tested on a device yet (to ensure no functional regressions in narrow mode on touch), will do when CI generates packages for the latest revision.
-- 
https://code.launchpad.net/~uriboni/webbrowser-app/topsite-previews/+merge/269771
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list