[Merge] lp:~uriboni/webbrowser-app/topsite-previews into lp:webbrowser-app
Ugo Riboni
ugo.riboni at canonical.com
Thu Oct 8 15:31:21 UTC 2015
> In narrow mode, the highlight for top site previews is cut off on the left
> hand side for the leftmost column.
Was due to clipping. Fixed.
> Also, keyboard navigation with arrows doesn’t ensure that the currently
> highlighted preview is visible (if e.g. the last row is out of sight and I
> navigate down to it with the down arrow key, it should come into view).
The issue here is that we are using a flickable around the GridView, and the GridView height equals its contentHeight, so as far as the GridView is concerned there is nothing to scroll.
I will fix this when adding full support for keyboard nav to the narrow view list (and replacing columns+repeaters with listviews) in a separate MR.
--
https://code.launchpad.net/~uriboni/webbrowser-app/topsite-previews/+merge/269771
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list