[Merge] lp:~uriboni/webbrowser-app/topsite-previews into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue Oct 6 17:10:29 UTC 2015


I expressed a concern about app startup performance for the branch where you made the bookmarks model a singleton, and this holds true for the changes done to the history model in this branch. Probably even more so, because the history model is likely to grow substantially over time. Please do some profiling to confirm/invalidate.

In BrowserTab.qml, there are extraneous semi-colons at line ends in JS code, please remove them for consistency.
-- 
https://code.launchpad.net/~uriboni/webbrowser-app/topsite-previews/+merge/269771
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list