[Merge] lp:~jamesh/camera-app/pre-cache-video-thumbnails into lp:camera-app

James Henstridge james.henstridge at canonical.com
Tue Oct 6 11:16:30 UTC 2015


James Henstridge has proposed merging lp:~jamesh/camera-app/pre-cache-video-thumbnails into lp:camera-app.

Commit message:
After shooting a video, request a thumbnail so that it will be available in the cache when needed (e.g. by the Gallery or Dash).

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~jamesh/camera-app/pre-cache-video-thumbnails/+merge/273515

Due to the bad performance of thumbnailing H.264 video files (on the order of a 1.4 seconds) I started investigating whether we could improve the user experience with a modification to camera-app.

This branch requests a small thumbnail after shooting a video with the camera-app, which will prime the thumbnailer-service's full-size image cache with a screenshot of the video, ready to provide thumbnails for whatever asks for one later (e.g. the "My Videos" scope on the dash, gallery-app, etc).

With this patch applied and an updated camera-app installed on my phone, I can see a thumbnail request in ~/.cache/upstart/dbus.log when I shoot a video.  If I switch back to the dash, the video shows up almost instantly rather than the old delay.

It wasn't clear where best to put this code, so if there is a better location I can update the branch.
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~jamesh/camera-app/pre-cache-video-thumbnails into lp:camera-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1734 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20151006/f45e10ed/attachment.diff>


More information about the Ubuntu-reviews mailing list