[Merge] lp:~uriboni/webbrowser-app/media-access into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Mon Oct 5 17:18:09 UTC 2015


Review: Needs Fixing functional

Can the "media access" entry in the settings go before the "reset browser settings" one?

"Media Access" should probably be spelled "Media access" to be consistent with other entries in the settings menu.

What about the informative message about needing to restart the browser for a domain permission to take effect, do we still want to display something like that?

Browsing to https://opentokrtc.com/foobarbaz, allowing both camera and microphone access, then I go to settings and disallow microphone access for that domain, restart the browser and I’m prompted for both permissions again. I would expect not to be prompted at all.

Similarly, if I do the above but instead of disallowing microphone access I forget the permission for this domain (by swiping to delete the entry), and after restarting the browser, I expect that the prompt would request microphone permission only (as camera was already granted). Instead, it prompts for both camera and microphone.

If I click anywhere outside the permission prompt, it is dismissed, but I have no idea whether the permission was granted or not. I think that dialog should be modal (or at least tab-modal) so it can’t be dismissed without explicitly choosing to allow or forbid media access.

-- 
https://code.launchpad.net/~uriboni/webbrowser-app/media-access/+merge/272919
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list