[Merge] lp:~uriboni/webbrowser-app/bookmarks-singleton into lp:webbrowser-app
Ugo Riboni
ugo.riboni at canonical.com
Mon Oct 5 13:39:35 UTC 2015
Ugo Riboni has proposed merging lp:~uriboni/webbrowser-app/bookmarks-singleton into lp:webbrowser-app.
Commit message:
Refactor the BookmarksModel to be a singleton.
Requested reviews:
Ubuntu Phablet Team (phablet-team)
For more details, see:
https://code.launchpad.net/~uriboni/webbrowser-app/bookmarks-singleton/+merge/273402
Refactor the BookmarksModel to be a singleton, since it does not make sense to have more than one instance of it across the application, and as a singleton we can access it from anywhere without having to pass the instance reference around between components.
--
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~uriboni/webbrowser-app/bookmarks-singleton into lp:webbrowser-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 16529 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20151005/8b18b14d/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list