[Merge] lp:~phablet-team/network-manager/lp1480877-wifi-rm-dup-scan-signals-vivid into lp:~phablet-team/network-manager/vivid-phone-overlay

[Tony Espy]

Tony Espy has proposed merging lp:~phablet-team/network-manager/lp1480877-wifi-rm-dup-scan-signals-vivid into lp:~phablet-team/network-manager/vivid-phone-overlay.

Requested reviews:
  Mathieu Trudel-Lapierre (mathieu-tl)
Related bugs:
  Bug #1480877 in network-manager (Ubuntu): "Access points' "PropertiesChanged" dbus signals freeze UI on mobile devices"
  https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1480877

For more details, see:
https://code.launchpad.net/~phablet-team/network-manager/lp1480877-wifi-rm-dup-scan-signals-vivid/+merge/273137

This change fixes a problem where duplicate (2-3x) AccessPoint 'LastSeen' PropertiesChanged signals are generated each time a WiFi scan completes. This can be seen by running:

dbus-monitor --system --profile "type='signal',sender='org.freedesktop.NetworkManager'"

...and waiting for a scan to occur. You'll see 2-3 PropsChanged for each AccessPoint after a scan. From then on, you'll only see changes for AccessPoint/0 until the next scan happens.

The change makes cull_scan_list the function responsible for updating an AP's last-seen property, and ensures that scan_done_cb is the only function that calls cull_scan_list. It also removes the bss_updated_cb function, as its only purpose was to update the last-seen property and schedule yet another scanlist cull.
-- 
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/network-manager/vivid-phone-overlay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 7291 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20151001/f3a5d244/attachment-0001.diff>