[Merge] lp:~canonical-platform-qa/camera-app/drag_too_fast_to_open into lp:camera-app/staging
Florian Boucault
florian.boucault at canonical.com
Thu Nov 26 12:30:36 UTC 2015
Florian Boucault has proposed merging lp:~canonical-platform-qa/camera-app/drag_too_fast_to_open into lp:camera-app/staging.
Commit message:
Remove rate parameter from drag call in _drag_to_open as it was not opening the panel when dragged that fast.
Requested reviews:
Ubuntu Phablet Team (phablet-team)
Related bugs:
Bug #1520171 in camera-app: "Panel._drag_to_open helper drags too quickly, drag not registered"
https://bugs.launchpad.net/camera-app/+bug/1520171
For more details, see:
https://code.launchpad.net/~canonical-platform-qa/camera-app/drag_too_fast_to_open/+merge/278690
The _drag_to_open helper was passing a rate=sys.maxintsize to the drag command. This represents a very fast drag action and apparently this wasn't being registered so the panel didn't open.
Removing the parameter to use the default drag speed fixes it.
--
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~canonical-platform-qa/camera-app/drag_too_fast_to_open into lp:camera-app/staging.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 538 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20151126/260028b4/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list