[Merge] lp:~dandrader/qtubuntu/useApplicationStateAPI into lp:qtubuntu

Gerry Boland gerry.boland at canonical.com
Fri Nov 20 15:35:14 UTC 2015


Review: Needs Fixing

+    case ApplicationState:
+        return true;
+ break;
no need to break if you return.

- QWindowSystemInterface::handleWindowActivated(window(), Qt::ActiveWindowFocusReason);
that is a weird line to exist. Alberto added it, with comment "Ignore unfocusing events", would like to know why.

Otherwise code looks ok, need to test
-- 
https://code.launchpad.net/~dandrader/qtubuntu/useApplicationStateAPI/+merge/277720
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list