[Merge] lp:~renatofilho/address-book-app/keyboard-navigation into lp:address-book-app

Bill Filler bill.filler at canonical.com
Thu Nov 19 21:00:31 UTC 2015


Review: Needs Fixing

Some problems:

1) Ctrl F to search, then type your search string, press enter, down arrow should navigate to first item in results list and select it

2) When at top of the contact list and press up arrow focus should go to the section selector
a) right/left arrow in section selector should navigate between sections
b) down arrow when in section selector should navigate back to list 

3) After saving a new contact, the new contact should be selected in the list and scrolled into view, but this is not working and first item in list is selected instead.

4) When you create a new contact and cancel (via esc), we should either select what was previously selected or the first item, but something should be selected. Currently nothing selected and right panel is blank which is not desirable.

5) When you enter edit mode, focus needs to be placed in the first field

6) In edit mode, Up/Down arrow keys should navigate the fields on the edit screen same as tabs do

7) In edit mode, left arrow key should bring focus back to contact list, if in contact list right arrow should navigate to first field in edit mode

8) Seeing of lots of these errors in log: file:///usr/share/address-book-app/imports/ABContactEditorPage.qml:45:9: QML Action: Invalid shortcut:

8)
-- 
https://code.launchpad.net/~renatofilho/address-book-app/keyboard-navigation/+merge/277176
Your team Ubuntu Phablet Team is subscribed to branch lp:address-book-app.



More information about the Ubuntu-reviews mailing list