[Merge] lp:~uriboni/webbrowser-app/newtabview-listviews into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Wed Nov 18 14:41:52 UTC 2015


308 +            removable: url != homeBookmarkUrl

This condition is not correct: what if the user has added the homepage as a bookmark, manually? They should be allowed to remove it. It would probably be more correct to make that depend on the index (i.e. only the first in the list cannot be removed).

Can we consider adding the homepage bookmark to the BookmarksModel at the C++ level, instead of jumping through hoops to prepend it in javascript? We could add a 'removable' role to the model.
-- 
https://code.launchpad.net/~uriboni/webbrowser-app/newtabview-listviews/+merge/274986
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list