[Merge] lp:~brian-murray/ubuntu-release-upgrader/patching-get-distro into lp:ubuntu-release-upgrader

[Brian Murray]

Brian Murray has proposed merging lp:~brian-murray/ubuntu-release-upgrader/patching-get-distro into lp:ubuntu-release-upgrader.

Requested reviews:
  Barry Warsaw (barry)
Related bugs:
  Bug #1511783 in ubuntu-release-upgrader (Ubuntu): "release upgrader can create a too minimal sources.list"
  https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1511783

For more details, see:
https://code.launchpad.net/~brian-murray/ubuntu-release-upgrader/patching-get-distro/+merge/277770

I want to update the code that only adds new mirrors to ubuntu-release-upgrader to also remove mirrors. However, if that change is made and you have an obsolete mirror you'll be left with a sources.list file that only contains main for the destination release. This'll result in a bad upgrade experience. See the linked bug for details.

I've modified the release upgrader to copy the disabled entries in sources.list and replace the server uri so that the upgrade will proceed and not leave a bunch of packages unupgraded. I've added a test, test_sources_list_inactive_mirror, for this.
-- 
Your team Ubuntu Core Development Team is subscribed to branch lp:ubuntu-release-upgrader.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 18256 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20151117/34cdb94d/attachment-0001.diff>