[Merge] lp:~osomon/webbrowser-app/missing-import-statements-bookmark-views into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue Nov 17 17:20:59 UTC 2015


> All good but please change the name to something less vague, like
> WebbrowserTestCase or something like that.

Done, although I’m not very fond of that name (those tests can target the webapp container too). I don’t have any better name to suggest though, so I went with your suggestion.


> In swipeToDeleteAndConfirm I don't see the point in having
> configurable x and dx.

Indeed this is not necessary. Removed.
-- 
https://code.launchpad.net/~osomon/webbrowser-app/missing-import-statements-bookmark-views/+merge/277366
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list