[Merge] lp:~aacid/qtubuntu/clazy_fixes into lp:qtubuntu

Albert Astals Cid albert.astals at canonical.com
Tue Nov 17 13:45:42 UTC 2015


Albert Astals Cid has proposed merging lp:~aacid/qtubuntu/clazy_fixes into lp:qtubuntu with lp:~albaguirre/qtubuntu/use-mir-surface-apis as a prerequisite.

Commit message:
Improvements from running clazy over the code

* Add some missing overrides
* Wrap const char * into QStringLiteral
* Use new connect syntax
* Don't call data() on temporary QByteArray as it detaches

clazy: https://quickgit.kde.org/?p=clazy.git

Requested reviews:
  Gerry Boland (gerboland): code
  PS Jenkins bot (ps-jenkins): continuous-integration

For more details, see:
https://code.launchpad.net/~aacid/qtubuntu/clazy_fixes/+merge/277686
-- 
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 7455 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20151117/07958451/attachment.diff>


More information about the Ubuntu-reviews mailing list