[Merge] lp:~dandrader/qtubuntu/cursor into lp:qtubuntu

Daniel d'Andrada daniel.dandrada at canonical.com
Mon Nov 16 14:15:43 UTC 2015


On 13/11/2015 13:49, Lukáš Tinkl wrote:
> Review: Needs Fixing
>
> mShapeToCursorName[Qt::ArrowCursor] = "left_ptr";
>
> You should probably use the predefined values from <mir_toolkit/cursors.h> (in case Mir decides to move away from X cursors in the future, unlikely but still better be safe)

But the Cursor plugin in unity8 uses xcursors. And that's *all* that 
matters.

-- 
https://code.launchpad.net/~dandrader/qtubuntu/cursor/+merge/277285
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~dandrader/qtubuntu/cursor into lp:qtubuntu.



More information about the Ubuntu-reviews mailing list